Compile support for HP-UX

[michael-o]

Since this is a dependency for Subversion, to whom it may concern, this makes utf8proc compile on HP-UX:

--- Makefile     2019-03-30 21:34:11 +0000
+++ Makefile     2019-04-30 16:12:53 +0000
@@ -5,2 +5,2 @@
-CC?=gcc
-INSTALL=install
+CC?=${CC}
+INSTALL=${INSTALL}
@@ -12,3 +12,3 @@
-PICFLAG = -fPIC
-C99FLAG = -std=c99
-WCFLAGS = -Wall -pedantic
+PICFLAG = +z
+C99FLAG = -Ae
+WCFLAGS = +w
@@ -37,2 +37,2 @@
-prefix=/usr/local
-libdir=$(prefix)/lib
+prefix=${PREFIX}
+libdir=${LIBDIR}
@@ -82 +82 @@
-       $(CC) $(LDFLAGS) -shared -o $@ -Wl,-soname -Wl,libutf8proc.so.$(MAJOR) utf8proc.o
+       $(CC) $(LDFLAGS) -b -o $@ -Wl,+h -Wl,libutf8proc.so.$(MAJOR) utf8proc.o

Notes:

• CC should point to aCC or some other compiler from HPE.
• The required install comes from GNU coreutils and is not available on HP-UX, one can steal install-sh from Subversion, for example.
• prefix: This is System V UNIX, there is no /usr/local (BSD), use /opt or alike,
• libdir There is also no ../lib, but needs to be either .../lib/hpux32 or .../lib/hpux64.

[ararslan]

If we can identify HP-UX during the build, we should be able to stick this stuff in a conditional so that it gets picked up and used on HP-UX and ignored elsewhere.

[michael-o]

Should this happen in the Makefile directly?

[ararslan]

That would be my thinking, yeah.

[michael-o]

Alright, will work out this week.

[stevengj]

Does cmake handle this for us?

I would prefer to keep the makefile small and simple for developer builds, and tell all other platforms to use cmake … otherwise we start re-inventing autoconf.

[michael-o]

We do also use cmake for legacy code, but I like to avoid depending on cmake for two reasons: from version 3.10 it requires libuv which is not available for HP-UX and it is a beast for two C files to compile. GNU zutoconf is at least just shell.

[stevengj]

We could just add instructions somewhere in the docs that the bundled Makefile is for GNU-style compilers, and for HP-UX with the HP compilers you should compile with

make CC=aCC PICFLAG=+z C99FLAG=-Ae WCFLAGS=+w prefix=whatever

and maybe add a make variable SOFLAGS or something for the -Wl options.

To automate this without cmake, at some point you need to go the full libtool autotools route, which I'd like to avoid for such a simple package.

[michael-o]

Agreed, this is probably the best compromise.

[stevengj]

A PR with a make variable for SOFLAGS and a doc patch would be welcome.

[michael-o]

I will take care of that.

[michael-o]

Both PRs done. Looks good to me now:

$ gmake V=1 CC=/opt/aCC/bin/aCC CFLAGS=""  PICFLAG='+z' C99FLAG=-Ae INSTALL=/opt/ports/share/libtool/build-aux/install-sh WCFLAGS='+w' LDFLAG_SHARED=-b SOFLAG="-Wl,+h" prefix=/tmp/utf8proc libdir=/tmp/utf8proc/lib/hpux32 install
/opt/aCC/bin/aCC   +z -Ae +w -DUTF8PROC_EXPORTS  -c -o utf8proc.o utf8proc.c
"utf8proc.h", line 132: remark #2193-D: zero used for undefined preprocessing
          identifier "__GNUC__"
  #  elif __GNUC__ >= 4
          ^

"utf8proc.h", line 236: remark #4255-D: padding size of struct
          "utf8proc_property_struct" with 2 bytes to alignment boundary
  typedef struct utf8proc_property_struct {
                 ^

"utf8proc.c", line 372: remark #4272-D: conversion from "utf8proc_int32_t" to
          "const utf8proc_uint32_t" may lose sign
    return cl != UINT16_MAX ? seqindex_decode_index(cl) : c;
                                                    ^

"utf8proc.c", line 378: remark #4272-D: conversion from "utf8proc_int32_t" to
          "const utf8proc_uint32_t" may lose sign
    return cu != UINT16_MAX ? seqindex_decode_index(cu) : c;
                                                    ^

"utf8proc.c", line 384: remark #4272-D: conversion from "utf8proc_int32_t" to
          "const utf8proc_uint32_t" may lose sign
    return cu != UINT16_MAX ? seqindex_decode_index(cu) : c;
                                                    ^

"utf8proc.c", line 394: remark #2188-D: enumerated type mixed with another type
    return utf8proc_get_property(c)->category;
           ^

"utf8proc.c", line 439: remark #2188-D: enumerated type mixed with another type
      if (category == UTF8PROC_CATEGORY_ZS) utf8proc_decompose_lump(0x0020);
                                            ^

"utf8proc.c", line 441: remark #2188-D: enumerated type mixed with another type
        utf8proc_decompose_lump(0x0027);
        ^

"utf8proc.c", line 443: remark #2188-D: enumerated type mixed with another type
        utf8proc_decompose_lump(0x002D);
        ^

"utf8proc.c", line 444: remark #2188-D: enumerated type mixed with another type
      if (uc == 0x2044 || uc == 0x2215) utf8proc_decompose_lump(0x002F);
                                        ^

"utf8proc.c", line 445: remark #2188-D: enumerated type mixed with another type
      if (uc == 0x2236) utf8proc_decompose_lump(0x003A);
                        ^

"utf8proc.c", line 447: remark #2188-D: enumerated type mixed with another type
        utf8proc_decompose_lump(0x003C);
        ^

"utf8proc.c", line 449: remark #2188-D: enumerated type mixed with another type
        utf8proc_decompose_lump(0x003E);
        ^

"utf8proc.c", line 450: remark #2188-D: enumerated type mixed with another type
      if (uc == 0x2216) utf8proc_decompose_lump(0x005C);
                        ^

"utf8proc.c", line 452: remark #2188-D: enumerated type mixed with another type
        utf8proc_decompose_lump(0x005E);
        ^

"utf8proc.c", line 454: remark #2188-D: enumerated type mixed with another type
        utf8proc_decompose_lump(0x005F);
        ^

"utf8proc.c", line 455: remark #2188-D: enumerated type mixed with another type
      if (uc == 0x02CB) utf8proc_decompose_lump(0x0060);
                        ^

"utf8proc.c", line 456: remark #2188-D: enumerated type mixed with another type
      if (uc == 0x2223) utf8proc_decompose_lump(0x007C);
                        ^

"utf8proc.c", line 457: remark #2188-D: enumerated type mixed with another type
      if (uc == 0x223C) utf8proc_decompose_lump(0x007E);
                        ^

"utf8proc.c", line 461: remark #2188-D: enumerated type mixed with another type
          utf8proc_decompose_lump(0x000A);
          ^

"utf8proc.c", line 742: remark #2188-D: enumerated type mixed with another type
    utf8proc_map(str, 0, &retval, UTF8PROC_NULLTERM | UTF8PROC_STABLE |
                                  ^

"utf8proc.c", line 749: remark #2188-D: enumerated type mixed with another type
    utf8proc_map(str, 0, &retval, UTF8PROC_NULLTERM | UTF8PROC_STABLE |
                                  ^

"utf8proc.c", line 756: remark #2188-D: enumerated type mixed with another type
    utf8proc_map(str, 0, &retval, UTF8PROC_NULLTERM | UTF8PROC_STABLE |
                                  ^

"utf8proc.c", line 763: remark #2188-D: enumerated type mixed with another type
    utf8proc_map(str, 0, &retval, UTF8PROC_NULLTERM | UTF8PROC_STABLE |
                                  ^

"utf8proc.c", line 770: remark #2188-D: enumerated type mixed with another type
    utf8proc_map(str, 0, &retval, UTF8PROC_NULLTERM | UTF8PROC_STABLE |
                                  ^

"utf8proc.c", line 642, procedure utf8proc_normalize_utf32: warning #20200-D:
          Potential null pointer dereference through starter_property is
          detected (null definition:utf8proc.c, line 604)

rm -f libutf8proc.a
ar rs libutf8proc.a utf8proc.o
ar: libutf8proc.a wird erstellt.
/opt/aCC/bin/aCC  -b -o libutf8proc.so.2.2.0 -Wl,+h -Wl,libutf8proc.so.2 utf8proc.o
chmod a-x libutf8proc.so.2.2.0
ln -f -s libutf8proc.so.2.2.0 libutf8proc.so
ln -f -s libutf8proc.so.2.2.0 libutf8proc.so.2
sed \
        -e 's#PREFIX#/tmp/utf8proc#' \
        -e 's#LIBDIR#lib/hpux32#' \
        -e 's#INCLUDEDIR#include#' \
        -e 's#VERSION#2.2.0#' \
        libutf8proc.pc.in > libutf8proc.pc
mkdir -m 755 -p /tmp/utf8proc/include
/opt/ports/share/libtool/build-aux/install-sh -m 644 utf8proc.h /tmp/utf8proc/include
mkdir -m 755 -p /tmp/utf8proc/lib/hpux32
/opt/ports/share/libtool/build-aux/install-sh -m 644 libutf8proc.a /tmp/utf8proc/lib/hpux32
/opt/ports/share/libtool/build-aux/install-sh -m 755 libutf8proc.so.2.2.0 /tmp/utf8proc/lib/hpux32
mkdir -m 755 -p /tmp/utf8proc/lib/hpux32/pkgconfig
/opt/ports/share/libtool/build-aux/install-sh -m 644 libutf8proc.pc /tmp/utf8proc/lib/hpux32/pkgconfig/libutf8proc.pc
ln -f -s libutf8proc.so.2.2.0 /tmp/utf8proc/lib/hpux32/libutf8proc.so
ln -f -s libutf8proc.so.2.2.0 /tmp/utf8proc/lib/hpux32/libutf8proc.so.2

Waiting for review and merge.

[stevengj]

Merged.

[michael-o]

Thanks for merging...