Fixes allowing for “Full” folding and NFKC_CaseFold compliance.#102
Closed
nomoon wants to merge 3 commits intoJuliaStrings:masterfrom
nomoon:case_folding_fixes
Closed
Fixes allowing for “Full” folding and NFKC_CaseFold compliance.#102nomoon wants to merge 3 commits intoJuliaStrings:masterfrom nomoon:case_folding_fixes
nomoon wants to merge 3 commits intoJuliaStrings:masterfrom
nomoon:case_folding_fixes
Conversation
* Only include C (Common) and F (Full) foldings from CaseFolding.txt. Removed S (Simple) since F & S are specified to be exclusive. * Extend UTF8PROC_IGNORE to also ignore unassigned codepoints (such as \u2065) which are specified as being discarded by NFKC_CF.
Author
|
It appears the tests are failing because I didn't generate and commit the new |
Member
|
Would be good to merge an updated version of this PR... |
stevengj
reviewed
Apr 27, 2018
| * NFKC_Casefold normalization (@ref UTF8PROC_COMPOSE and @ref UTF8PROC_COMPAT | ||
| * and @ref UTF8PROC_CASEFOLD and @ref UTF8PROC_IGNORE). | ||
| **/ | ||
| UTF8PROC_DLLEXPORT utf8proc_uint8_t *utf8proc_NFKC_CF(const utf8proc_uint8_t *str); |
Member
There was a problem hiding this comment.
Probably just call it NFKC_Casefold since that is the standard name.
Member
|
Closed in favor of the updated PR, #133. |
Member
|
Closed by #133. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
C(Common) &F(Full) foldings from CaseFolding.txt data. RemovedS(Simple) sinceF&Sare specified to be exclusive. I'm not sure if it was causing issues, but it's technically an error.UTF8PROC_IGNOREto also ignore unassigned codepoints (such as \u2065) which are specified as being discarded by NFKC_CF.With these changes, compliant NFKC_CaseFolding should be achievable with the options
UTF8PROC_STABLE | UTF8PROC_COMPOSE | UTF8PROC_COMPAT | UTF8PROC_CASEFOLD | UTF8PROC_IGNOREShould resolve #54 (though it was already mostly resolved?)
(This PR doesn't include the new
utf8proc_data.cfile since there's no point in generating it multiple times if changes are needed.)