Skip to content

[CMake] Add UTF8PROC_NO_INSTALL option#152

Merged
stevengj merged 2 commits intoJuliaStrings:masterfrom
past-due:cmake_no_install_option
Apr 17, 2019
Merged

[CMake] Add UTF8PROC_NO_INSTALL option#152
stevengj merged 2 commits intoJuliaStrings:masterfrom
past-due:cmake_no_install_option

Conversation

@past-due
Copy link
Copy Markdown
Contributor

In some cases (such as using the library via add_subdirectory in CMake), it may be desirable to disable installation.

@stevengj
Copy link
Copy Markdown
Member

Thanks, seems reasonable, though it would be better if cmake provided a cleaner way to do this from the parent (as is discussed in various places online, e.g. https://stackoverflow.com/questions/35344132/cpack-exclude-install-commands-from-subdirectory-googletest-directory/35345933, glfw/glfw#30, ...)

I modifed the PR so that it is UTF8PROC_INSTALL=No, however.

@stevengj stevengj merged commit 4167498 into JuliaStrings:master Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants