Merged
Conversation
Member
|
Thanks! It would be good to make it more similar to the Travis script (https://github.com/JuliaStrings/utf8proc/blob/master/.travis.yml), in that it should test the Makefile as well as cmake with both static and shared builds, |
Author
My understanding is that the The part that tests |
Author
|
Now make.yml works. Two changes are needed to enable MANIFEST testing on the mac
--- MANIFEST.new 2021-10-10 21:49:40.000000000 +0800
+++ MANIFEST 2021-10-09 22:18:38.000000000 +0800
@@ -1,9 +1,8 @@
include/
include/utf8proc.h
lib/
+lib/libutf8proc.2.dylib
lib/libutf8proc.a
-lib/libutf8proc.so -> libutf8proc.so.2.4.1
-lib/libutf8proc.so.2 -> libutf8proc.so.2.4.1
-lib/libutf8proc.so.2.4.1
+lib/libutf8proc.dylib -> libutf8proc.2.dylib
lib/pkgconfig/
lib/pkgconfig/libutf8proc.pc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build on: ubuntu, windows, macOS, win+mingw64
Fix #206
We can add more combinations if needed, for example: ubuntu+mingw64, win+cygwin, *+clang.
Results of CI run: https://github.com/inkydragon/utf8proc/actions/runs/1324116342