Merged
Conversation
Closed
Member
Author
|
Regarding the symlinks, I wasn't sure whether creating them would make any sense on OSX. |
Makefile
Outdated
Member
There was a problem hiding this comment.
Probably better to do ln -f -s $(libdir)/libutf8proc.$(SHLIB_VERS_EXT) .... since we have this var, for consistency.
nalimilan
force-pushed
the
nalimilan/destdir
branch
from
9d31fae to
f85e76a
Compare
Makefile
Outdated
Member
There was a problem hiding this comment.
I guess it is harmless, and may be a bit clearer to read if someone is wondering where DESTDIR comes from.
Member
Author
There was a problem hiding this comment.
Ah, I just removed it...
Useful to build distribution packages.
nalimilan
force-pushed
the
nalimilan/destdir
branch
from
f85e76a to
1b7ba89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this I'm able to build the RPM package fine.