Skip to content

Fix MingW build test#57

Merged
stevengj merged 2 commits into
JuliaStrings:masterfrom
petercolberg:master
Oct 30, 2015
Merged

Fix MingW build test#57
stevengj merged 2 commits into
JuliaStrings:masterfrom
petercolberg:master

Conversation

@petercolberg

Copy link
Copy Markdown
Contributor

Fix MingW build test

@aviks aviks changed the title Fix MingW build [WIP] Fix MingW build Oct 30, 2015
@aviks

aviks commented Oct 30, 2015

Copy link
Copy Markdown

@petercolberg I've added the [WIP] tag to the title to indicate that this is experimental. Please take it out once this PR is ready.

@tkelman

tkelman commented Oct 30, 2015

Copy link
Copy Markdown
Contributor

The problem is that cd /c/projects/utf8proc is failing in msys, not the choice of generator. mingw make is a crippled version that is enough to build utf8proc but not much else.

@petercolberg

Copy link
Copy Markdown
Contributor Author

If the line that creates /etc/fstab is removed, then cd /c/projects/utf8proc succeeds.

The build freezes as soon as cmake … -G'MSYS Makefiles' is executed.

@petercolberg

Copy link
Copy Markdown
Contributor Author

I could finally trigger the following graphical error dialog in the interactive session:

cc1.exe: The program can't start because libgmp-10.dll is missing from your computer.
Try reinstalling the program to fix this problem.

This is why cmake hangs when using the MSYS Makefiles generator.

@tkelman

tkelman commented Oct 30, 2015

Copy link
Copy Markdown
Contributor

That sounds like a broken toolchain installation, cc @FeodorFitsner. So changing the generator must be either changing which mingw compiler is getting run, or modifying the path so it's able to find libgmp.

@petercolberg

Copy link
Copy Markdown
Contributor Author

It’s already fixed. Please review after the Travis build succeeds.

@petercolberg petercolberg changed the title [WIP] Fix MingW build Fix MingW build test Oct 30, 2015
@stevengj

Copy link
Copy Markdown
Member

Looks great, thanks for following up on this!

stevengj added a commit that referenced this pull request Oct 30, 2015
@stevengj stevengj merged commit f67f1a7 into JuliaStrings:master Oct 30, 2015
@petercolberg petercolberg mentioned this pull request Nov 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants