Skip to content

test(grok): PR #844 left command-catalog and media-census baselines stale #1016

Closed

Description

@Juliusolsson05

Expected

After merging a provider integration, characterization/census test baselines are updated in the same PR.

Actual

On main @ 5fda2f0 (post PR #844), 4 unit tests fail:

  • src/renderer/src/features/command-palette/catalog.test.ts — 3 failures: catalog now registers 134 commands; the characterization baseline says 132 (grok added palette commands without bumping the governed list and the arithmetic target: 104 vs 102).
  • src/providers/shared/renderer/protocols/media/imageAttachment.test.ts — "every fixture is traceable to a census row and a real session": new grok fixtures (e.g. testing/fixtures/grok-session-feed/) are not recorded in the census.

Impact

Red unit CI for everyone after the merge; hides real regressions in these suites.

Fix direction

Update the governed command list / arithmetic in catalog.test.ts (verify the two new commands are intentional and correctly registered) and add the grok fixtures to the media census. Pre-existing on main, discovered while verifying #1014's fix (which is unrelated).

Activity

  1. Juliusolsson05 commented on Sep 19, 2026

    @Juliusolsson05
    OwnerAuthor

    Triage update (2026-09-19): of the two failures listed, only the command-catalog one is real on CI. It is fixed by #1019.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions