test(goal-loop): GoalLoopService tests leave persistence running after cleanup (ENOENT noise) #1341

Expected

Each GoalLoopService.test.ts case finishes its own async work (fire-and-forget persist() / maybeContinue()) before afterEach removes its temp directory.

Actual

The tests leave async persistence running after they end. afterEach deletes the temp dir, and the late GoalLoopStore.write() then logs [goal-loop] persisting loop state failed: ENOENT … rename …goal-loop.json.<uuid>.tmp. Main CI run 36156560842 has 13 such warnings against 13 distinct temp dirs (12 rename, 1 open), all in the GoalLoopService worker.

Impact

Test hygiene, not user state: the errors are caught, and all the paths are test temp dirs. But the leftover work adds noise and can perturb fake-timer/I/O ordering in later cases in the same worker, which is the class of race behind #1314.

Where

src/main/goalLoop/GoalLoopService.test.ts (afterEach at the top) against GoalLoopService.ts void this.persist() / void this.maybeContinue().

Fix direction

Give the service a test-only drain (await in-flight continuations and persists), or stop the service before cleanup; do not swallow the log.

Found by review c of #1337 (issue #1314). P3.

🤖 Generated with Claude Code