Skip to content

feat: vendor agent-voice-dictation as packages/ submodule - #33

Merged
Juliusolsson05 merged 1 commit into
mainfrom
feat/dictation-package-submodule
Apr 29, 2026
Merged

Juliusolsson05 merged 1 commit into
mainfrom
feat/dictation-package-submodule

Conversation

@Juliusolsson05

Copy link
Copy Markdown
Owner

Summary

  • Vendor the dictation package as a git submodule at packages/agent-voice-dictation, alongside the other local packages.
  • Switch the vite alias and tsconfig path to compile from packages/agent-voice-dictation/src instead of a sibling-directory ../agent-voice-dictation/dist.
  • A fresh clone with `--recurse-submodules` now just works — no hidden "remember to build the dist out-of-tree first" ordering trap.

Why

The previous setup loaded the dictation package from `file:../agent-voice-dictation/dist/index.js`. That meant cloning cc-shell on a clean machine would silently break unless you also cloned the dictation repo as a sibling and built it first. Submoduling under `packages/` fixes the bootstrap and matches how `agent-transcript-parser`, `claude-code-headless`, and `codex-headless` are laid out.

Test plan

  • `npm run build` (renderer + main + preload bundles successfully)
  • `npm run test:dictation` (verified in prior session)
  • Reviewer: clone with `--recurse-submodules` and run `npm install && npm run build` to confirm the bootstrap

🤖 Generated with Claude Code

Move agent-voice-dictation from a sibling-directory ../agent-voice-dictation
file:// dep to a git submodule under packages/, alongside the other local
packages. The vite alias and tsconfig path now point at the submodule's
source (packages/agent-voice-dictation/src), so a fresh clone with
--recurse-submodules just works — no hidden requirement to build the
sibling dist before installing.

- .gitmodules: register packages/agent-voice-dictation
- package.json: file:./packages/agent-voice-dictation
- electron.vite.config.ts, tsconfig.node.json: alias to src/, not dist/
- packages/agent-voice-dictation: submodule pointer

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@Juliusolsson05
Juliusolsson05 merged commit e4fd303 into main Apr 29, 2026
@Juliusolsson05
Juliusolsson05 deleted the feat/dictation-package-submodule branch April 29, 2026 22:06
Juliusolsson05 added a commit that referenced this pull request Sep 19, 2026
…ant (#33)

Only src and test changes, so package.json and the lockfile are unchanged.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Juliusolsson05 added a commit that referenced this pull request Sep 19, 2026
…saved variant

The #1034 review found, against the 1.18.31 binary:
1. MEDIUM: the switched session carried no reasoning variant, and
   OpenCode Terminal restores and SAVES the variant from the last user
   message. Opening the session reset the user's glm-5.3 "max" to
   "default" in model.json. The variant from model.json now rides on
   the target profile, and the projector stamps it (parser #33).
2. MEDIUM: a user with no recents could no longer switch, Duplicate or
   Rewind. OpenCode falls back to its provider default, and so does this,
   through the catalog's first row.
3. LOW: the configured model was trusted without checking the catalog.
   Each candidate is now checked, as the TUI does.
4. LOW: the default agent's own model, which OpenCode ranks first, was
   ignored.

selectOpencodeTargetModel is the one pure rule. readOpencodeModelState
reads recents and variants together.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant