Repository navigation
Fix: command palette resume uses the focused pane's actual provider - #411
Merged
Merged
Conversation
The palette's resume flow determined the provider three ways with `focusedProvider === 'codex' ? 'codex' : 'claude'` — a binary negation that silently collapsed every non-codex kind to Claude. Now that OpenCode is a registered provider (phase 7, #408), an opencode-focused resume picker listed CLAUDE sessions (listSessionsForCwd), and resuming spawned a CLAUDE pane — even though the picker header already read "resume opencode". Derive one `resumeProvider` from the focused pane's real kind (guarded by isAgentProviderKind; terminal/unknown fall back to DEFAULT_PROVIDER) and use it at all three sites. An opencode pane now correctly lists opencode sessions (empty today — opencode has no offline session listing yet, #406 blocker 1 — which is the honest result, versus wrongly showing Claude sessions) and resumes into an opencode pane. Verified: tsc node+web 0; build ok; 170/170 tests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The command palette's resume flow determined the provider in three places with
focusedProvider === 'codex' ? 'codex' : 'claude'— a binary negation that silently collapsed every non-codex kind to Claude. Now that OpenCode is a registered provider (phase 7, #408):listSessionsForCwd), andreplaceSession/ resume descriptor)…even though the picker header already displayed "resume opencode" — a visible inconsistency.
Fix
Derive one
resumeProviderfrom the focused pane's real kind (guarded byisAgentProviderKind; terminal/unknown fall back toDEFAULT_PROVIDER) and use it at all three sites. An opencode pane now correctly lists opencode sessions (empty today — opencode has no offline session listing yet, #406 blocker 1 — the honest result, versus wrongly showing Claude sessions) and resumes into an opencode pane.Verification
tsc -p tsconfig.node.json→ 0 ·tsc --noEmit -p tsconfig.web.json→ 0electron-vite build✓ ·npm test→ 170/170🤖 Generated with Claude Code