Skip to content

fix(tldr): draw TLDR and Goal peeks in the theme's colors - #957

Merged
Juliusolsson05 merged 1 commit into
mainfrom
style/tldr-overlay-theme
Sep 13, 2026
Merged

Juliusolsson05 merged 1 commit into
mainfrom
style/tldr-overlay-theme

Conversation

@Juliusolsson05

Copy link
Copy Markdown
Owner

Problem

The TLDR and Goal peeks (Cmd+L / Cmd+G) drew a hard-coded bg-black/95 overlay with text-white, so they ignored the active theme. In a light theme they looked like a foreign black panel rather than part of the app.

Change

  • Overlay: uses bg-canvas text-ink, the same --theme-canvas / --theme-ink tokens that body uses. The canvas is opaque, so the pane's own text can't bleed through behind the summary.
  • Footer (Last active / Note written): text-white/60 becomes text-muted, the app's standard secondary text.
  • Wording: removed "darkened pane" and "white text over a dark overlay" from the README, command descriptions and control reference.

Verification

  • npm run typecheck passes.
  • TLDR renderer and command-palette suites: 245 of 246 tests passed in the combined run.
    • The one failure was the first Spotlight hold test, which timed out at 5 s.
    • That run shared the machine with a concurrent typecheck and other sessions' test runs, at a load average of about 134 on 8 cores.
    • The file passes 19/19 on its own, with 1.4 s of test time.
  • This change touches only class names and prose, and no test asserts overlay colors. A class-name test would only restate the markup, so none was added.
  • The app was not launched, per the project rule.

Notes

This is a small, self-evident style change, so there is no issue or plan document. Per the user, it skips the review round and merges once CI is green.

🤖 Generated with Claude Code

https://claude.ai/code/session_01W3VSuHMwJrrNMEk91tkaVU

The peek overlay was hard-coded black with white text, so it ignored the
active theme and looked foreign in light themes. It now uses the app's
canvas background and ink text (the same tokens body uses), with muted
footer text, so the peek reads as part of the UI.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W3VSuHMwJrrNMEk91tkaVU
@Juliusolsson05
Juliusolsson05 merged commit 173a570 into main Sep 13, 2026
2 checks passed
@Juliusolsson05
Juliusolsson05 deleted the style/tldr-overlay-theme branch September 13, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant