Skip to content

Bugfix/Update Logo Images#521

Merged
lnovitz merged 5 commits into
JustAJobApp:mainfrom
okimin:bugfix/update-logo
Jul 3, 2025
Merged

Bugfix/Update Logo Images#521
lnovitz merged 5 commits into
JustAJobApp:mainfrom
okimin:bugfix/update-logo

Conversation

@okimin
Copy link
Copy Markdown
Contributor

@okimin okimin commented Jul 1, 2025

Pull Request

Description

Changes the previous jobba images to just a job app images to reflect consistency.

Related Issue

Fixes #505

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update
  • 🎨 Style update (formatting, renaming)
  • ♻️ Code refactor (no functional changes)
  • ⚡️ Performance improvement
  • ✅ Test update
  • 🔨 Build configuration update
  • 🔒 Security update

Changes Made

  1. Changes apple-touch-icon favicon.svg and logo.png to just a job app logos.

Screenshots

Before

Screenshot 2025-07-01 at 4 16 01 PM

After

Screenshot 2025-07-01 at 4 27 48 PM

Testing

  1. Steps to reproduce:

    • docker-compose down
    • git checkout main
    • docker-compose up --build
    • View current images.
    • docker-compose down
    • git checkout
    • docker-compose up --build
  2. Test environment:

    • OS: Mac
    • Node version: current version
    • Browser (if applicable): Mac

Additional Notes

Change the SVG but didn't make it a circle shape. Will add as additional comment.

Reviewer Notes

Post-Deployment Steps

  • No post-deployment steps needed

By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.

@okimin
Copy link
Copy Markdown
Contributor Author

okimin commented Jul 1, 2025

Changed the SVG but didn't make it a circle shape. Any tips on how to make SVGs from the logo would be appreciated. Used online converters but couldn't change them into circle shapes afterward.

@lnovitz
Copy link
Copy Markdown
Collaborator

lnovitz commented Jul 2, 2025

Looking into circle shape... might have to recreate in Canva

@lnovitz
Copy link
Copy Markdown
Collaborator

lnovitz commented Jul 2, 2025

Does it need to be a circle? 😸

@okimin
Copy link
Copy Markdown
Contributor Author

okimin commented Jul 2, 2025

That's a valid question haha. Tried to make it so since jobba had the same shape. But just wasn't sure how to do that after converting it from png.

@lnovitz
Copy link
Copy Markdown
Collaborator

lnovitz commented Jul 3, 2025

JAJA-favicon

Hey Daniel, I think this favicon (attached) is a lot more readable when using the JAJA abbreviation. Better than having the whole text "Just A Job App".

Also upon my normal browsing behavior discovered that a lot of favicons are in fact square, not circles. So square is fine 👍

e.g. AWS is a square (pun slightly intended)
image

Copy link
Copy Markdown
Collaborator

@lnovitz lnovitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the inconvenience of regenerating but this should look a lot better 🙏
JAJA-favicon

@github-project-automation github-project-automation Bot moved this from Backlog to Todo in Just a Job App Jul 3, 2025
@lnovitz
Copy link
Copy Markdown
Collaborator

lnovitz commented Jul 3, 2025

JAJA-favicon

SVG (converted from png using https://www.adobe.com/express/feature/image/convert/svg)

@okimin
Copy link
Copy Markdown
Contributor Author

okimin commented Jul 3, 2025

Thank you so much Lianna. Changed the other images to JAJA abbreviation as well. This is what the current tab looks like right now :
image

@okimin okimin requested a review from lnovitz July 3, 2025 05:37
@lnovitz lnovitz merged commit e426550 into JustAJobApp:main Jul 3, 2025
1 check passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Just a Job App Jul 3, 2025
@okimin okimin deleted the bugfix/update-logo branch July 3, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[BUG]: Favicon is outdated

2 participants