Skip to content

[BUGFIX]: User Email Processing Failures#551

Merged
lnovitz merged 11 commits into
mainfrom
bugfix/550-clear-cookies
Jul 15, 2025
Merged

[BUGFIX]: User Email Processing Failures#551
lnovitz merged 11 commits into
mainfrom
bugfix/550-clear-cookies

Conversation

@lnovitz
Copy link
Copy Markdown
Collaborator

@lnovitz lnovitz commented Jul 15, 2025

Pull Request

Description

During user interviews, I would delete users so they could choose a different start date, and the cookies wouldn't clear which meant the session was likely getting invalidated on the processing page which meant they wouldn't be able to process their emails.

Related Issue

Fixes #550

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update
  • 🎨 Style update (formatting, renaming)
  • ♻️ Code refactor (no functional changes)
  • ⚡️ Performance improvement
  • ✅ Test update
  • 🔨 Build configuration update
  • 🔒 Security update

Changes Made

  1. Creates test factories for users and tasks with mocked validate_session dependency
  2. Adds function to clear cookies if session invalid or user deleted
  3. Adds .dockerignore excludes to reduce the number of watched files and avoid OSError: [Errno 24] Too many open files: '/app'
  4. Increases rate limit for fetch emails endpoint

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

API Changes

  • No API changes
  • API changes included (describe below):
    • processing endpoint now has a user_id database check

By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.

lnovitz added 8 commits July 14, 2025 19:50
- Introduced new test fixtures for task and user creation to streamline test setup.
- Updated existing tests to utilize the new fixtures, improving readability and maintainability.
- Added a test for processing redirection when the user is not logged in.
- Ensured that task status checks are performed on the latest state from the database.
@lnovitz lnovitz changed the title Bugfix/550 clear cookies [BUGFIX]: User Email Processing Failures Jul 15, 2025
@lnovitz lnovitz merged commit 77d5268 into main Jul 15, 2025
8 checks passed
@lnovitz lnovitz deleted the bugfix/550-clear-cookies branch July 15, 2025 06:41
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Just a Job App Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[BUG]: Clear cookies upon user deletion

1 participant