Skip to content

[Frontend] Fix Dark Theme UX and Color Contrast#723

Merged
lnovitz merged 20 commits into
JustAJobApp:mainfrom
code-qtzl:theme-contrast
Jan 21, 2026
Merged

[Frontend] Fix Dark Theme UX and Color Contrast#723
lnovitz merged 20 commits into
JustAJobApp:mainfrom
code-qtzl:theme-contrast

Conversation

@code-qtzl
Copy link
Copy Markdown
Collaborator

Pull Request

Description

PR Addressing Tasks Proposed

  • Update Theme Configuration: Refine the dark theme object in frontend/tailwind.config.js within the heroui() plugin.

  • Restore Theme Switcher: Re-integrate the ThemeSwitch component into frontend/components/navbar.tsx (ensure it's visible in the right-hand nav section).

  • Homepage Elevation Audit: Update frontend/app/page.tsx to ensure cards use the new colors

  • Accessibility Check: Verify that homepage meets WCAG AA contrast standards for readability.

Related Issue

Fixes #687

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update
  • 🎨 Style update (formatting, renaming)
  • ♻️ Code refactor (no functional changes)
  • ⚡️ Performance improvement
  • ✅ Test update
  • 🔨 Build configuration update
  • 🔒 Security update

Changes Made

Screenshots

coaches home

Audit


audit

Testing

  1. Steps to reproduce:

  2. Test environment:
    • OS:
    • Node version:
    • Browser (if applicable):

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Dependencies

Database Changes

  • No database changes
  • Database changes included (describe below):

API Changes

  • No API changes
  • API changes included (describe below):

Performance Impact

  • No performance impact
  • Performance impact (describe below):

Security Considerations

  • No security implications
  • Security implications considered (describe below):

Additional Notes

Reviewer Notes

Post-Deployment Steps

  • No post-deployment steps needed
  • Post-deployment steps required (describe below):

By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.

@code-qtzl code-qtzl marked this pull request as ready for review January 19, 2026 20:42
@code-qtzl
Copy link
Copy Markdown
Collaborator Author

code-qtzl commented Jan 20, 2026

@lnovitz can you review the following PR?

Copy link
Copy Markdown
Collaborator

@lnovitz lnovitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have a quick question after cursory glance at the tailwind config file, there's a lot of 100/200/300/400/500 color variations available - are they all used or can we just remove the non-used and keep the variations that are being used?

@code-qtzl
Copy link
Copy Markdown
Collaborator Author

code-qtzl commented Jan 21, 2026

@lnovitz No, not for this version since there’s another version in progress. I went ahead and cleaned up the unused shades in this PR.

@github-project-automation github-project-automation Bot moved this from Backlog to Todo in Just a Job App Jan 21, 2026
@lnovitz lnovitz merged commit 2f0b928 into JustAJobApp:main Jan 21, 2026
1 check passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Just a Job App Jan 21, 2026
@code-qtzl code-qtzl deleted the theme-contrast branch February 11, 2026 05:06
@code-qtzl code-qtzl restored the theme-contrast branch February 11, 2026 05:06
@code-qtzl code-qtzl deleted the theme-contrast branch February 11, 2026 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Frontend] Fix Dark Theme UX and Color Contrast

2 participants