Node 6 compatibility

[ronkorving]

On Node 6.0.0, I see the following output when running npm test:

$ npm test

> zmq@2.15.0 test /Users/ronkorving/Projects/zeromq.node
> mocha --expose-gc --slow 2000 --timeout 600000

(node:87405) DeprecationWarning: child_process: options.customFds option is deprecated. Use options.stdio instead.
(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated
(node) and will stop working in the next major release.

==== JS stack trace =========================================

Security context: 0x3f92617c9fa9 <JS Object>#0#
    1: .node [module.js:568] [pc=0x241fb9a9a784] (this=0xb50fd4f11c9 <an Object with map 0x173dba817c91>#1#,module=0x1bdf500abb11 <a Module with map 0x173dba818269>#2#,filename=0x1bdf500abad9 <String[61]: /Users/ronkorving/Projects/zeromq.node/build/Release/zmq.node>)
    2: load [module.js:456] [pc=0x241fb9a3a132] (this=0x1bdf500abb11 <a Module with map 0x173dba818269>#2#,filename=0x1bdf500abad9 <String[61]: /Users/ronkorving/Projects/zeromq.node/build/Release/zmq.node>)
    3: tryModuleLoad(aka tryModuleLoad) [module.js:415] [pc=0x241fb9a39c5d] (this=0x3f9261704189 <undefined>,module=0x1bdf500abb11 <a Module with map 0x173dba818269>#2#,filename=0x1bdf500abad9 <String[61]: /Users/ronkorving/Projects/zeromq.node/build/Release/zmq.node>)
    4: _load [module.js:407] [pc=0x241fb9a358a2] (this=0xb50fd4e75a9 <JS Function Module (SharedFunctionInfo 0xb50fd429979)>#3#,request=0x1bdf500aaf11 <String 1: v8::Template::Set(v8::Local<v8::Name>, v8::Local<v8::Data>, v8::PropertyAttribute)
 2: zmq::Context::Initialize(v8::Local<v8::Object>)
 3: init
 4: node::DLOpen(v8::FunctionCallbackInfo<v8::Value> const&)
 5: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&))
 6: v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::(anonymous namespace)::BuiltinArguments<(v8::internal::BuiltinExtraArguments)1>)
 7: v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*)
 8: 0x241fb990961b
 9: 0x241fb9a9a784
(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated
(node) and will stop working in the next major release.

==== JS stack trace =========================================

Security context: 0x3f92617c9fa9 <JS Object>#0#
    1: .node [module.js:568] [pc=0x241fb9a9a784] (this=0xb50fd4f11c9 <an Object with map 0x173dba817c91>#1#,module=0x1bdf500abb11 <a Module with map 0x173dba818269>#2#,filename=0x1bdf500abad9 <String[61]: /Users/ronkorving/Projects/zeromq.node/build/Release/zmq.node>)
    2: load [module.js:456] [pc=0x241fb9a3a132] (this=0x1bdf500abb11 <a Module with map 0x173dba818269>#2#,filename=0x1bdf500abad9 <String[61]: /Users/ronkorving/Projects/zeromq.node/build/Release/zmq.node>)
    3: tryModuleLoad(aka tryModuleLoad) [module.js:415] [pc=0x241fb9a39c5d] (this=0x3f9261704189 <undefined>,module=0x1bdf500abb11 <a Module with map 0x173dba818269>#2#,filename=0x1bdf500abad9 <String[61]: /Users/ronkorving/Projects/zeromq.node/build/Release/zmq.node>)
    4: _load [module.js:407] [pc=0x241fb9a358a2] (this=0xb50fd4e75a9 <JS Function Module (SharedFunctionInfo 0xb50fd429979)>#3#,request=0x1bdf500aaf11 <String 1: v8::Template::Set(v8::Local<v8::Name>, v8::Local<v8::Data>, v8::PropertyAttribute)
 2: zmq::Context::Initialize(v8::Local<v8::Object>)
 3: init
 4: node::DLOpen(v8::FunctionCallbackInfo<v8::Value> const&)
 5: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&))
 6: v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::(anonymous namespace)::BuiltinArguments<(v8::internal::BuiltinExtraArguments)1>)
 7: v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*)
 8: 0x241fb990961b
 9: 0x241fb9a9a784
(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated
(node) and will stop working in the next major release.

followed by a million more stack traces. We'll need to look into this.

[ralphtheninja]

@ronkorving I think this is related to nan, see nodejs/nan#560

[ralphtheninja]

We have the same issue when running npm test on leveldown

[ralphtheninja]

@ronkorving I just noticed that nan@2.3.0 fixes this problem for leveldown

[matthiasg]

using nan@2.3.2 did not solve this issue for me.

[thedillonb]

Moving to nan@2.3.0 via #522 resolved the deprecation warnings for me. I suggest that PR be merged in and we get to partying 🎉

[ronkorving]

Solved in master

[matthiasg]

any idea when this will be pushed to npm ?

[pjanuario]

same here, any information when this can be pushed into a new version?

[ronkorving]

Sorry guys, I'm on a 3 week holiday so have been kinda off the grid. I've pushed it out to NPM.

[matthiasg]

@ronkorving no worries. didn't want to sound impatient .. thanks for that !

[ronkorving]

It's cool :) I know how annoying it can be to wait without knowing what or when.