[Bug]: Repeated "metadata has changed" messages

[Silvia-Dragoness]

Is there an existing issue for this?

• I have searched the existing issues

Operating System

Windows 11

CKAN Version

1.32.0

KSP Version

KSP2 v0.1.2.0

Did you make manual changes?

No

Describe the bug

I periodically check for mod updates in CKAN throughout the day. This message showed up a few days ago, and I clicked "yes" and reinstalled the mod. Later that day, and a few times every day since, on subsequent mod list refreshes, the same message reappears for the same mod.

Initially reported in Discord; HebaruSan asked me to open an issue for it.

Steps to reproduce

• Have CheatsMenu installed via CKAN on KSP2
• Periodically refresh mod list in CKAN

Relevant log output

No response

[HebaruSan]

Could you please share your <game dir>/CKAN/registry.json file? This contains all the data that CKAN checks to determine whether to show that popup, so it should give us some insights.

[HebaruSan]

So far it looks like the installed_modules list in the registry doesn't get updated after reinstalling. I'm trying it via ModuleInstaller.Upgrade for another idea, and I'm seeing exactly that happen; the reinstall occurs (file timestamps all updated), but the old source_module is still there, somehow, even though it would be removed by the first loop of ModuleInstaller.AddRemove and has no way of returning (I tested with a custom edit that isn't reflective of the metadata repo).

So something very unexpected is happening, which almost certainly affects this case as well.

[HebaruSan]

For the case I'm investigating, the InstalledModule's .Module property is being passed to ModuleInstaller.Upgrade, so that's where the restored metadata comes from; it temporarily removes the object and then re-inserts the same object. That could also be what's happening in the OP, but that's not certain.

[HebaruSan]

Hi @Silvia-Dragoness, thanks for the report. I made some code changes in #3828, where you can download a test build from the Checks tab's Artifacts dropdown. If you have a chance, please take it for a test drive to see if it seems to fix the problem. The popup should be gone completely, the update checkbox should show up for this mod, and updating it should perform the reinstall properly and make it stop bothering you.