[Bug]: ValveKeyValue.KeyValueException: Found end of file when another token type was expected

[engiefox]

Is there an existing issue for this?

• I have searched the existing issues

Operating System

Windows 11

CKAN Version

1.35.0

Games

KSP 1

Game Version

1.12.5

Did you make any manual changes to your game folder (i.e., not via CKAN)?

No

Describe the bug

Launching CKAN after updating to 1.35.0 from 1.34.4 fails to launch, only displaying a command window with the attached log

Steps to reproduce

1. Have an .acf file in your Steam library with something weird about it (still investigating, but so far one user has found a file containing nothing but null bytes)
2. Go to ckan.exe
3. Click ckan.exe
4. wait for error

Workaround

Delete corrupted .acf files from your Steam library

Relevant log output

Unhandled Exception: ValveKeyValue.KeyValueException: Found end of file when another token type was expected. ---> System.InvalidOperationException: Attempted to finalize object while in state InObjectBetweenKeyAndValue.
   at ValveKeyValue.Deserialization.KV1TextReader.FinalizeCurrentObject(Boolean explicit)
   at ValveKeyValue.Deserialization.KV1TextReader.FinalizeDocument()
   at ValveKeyValue.Deserialization.KV1TextReader.ReadObject()
   --- End of inner exception stack trace ---
   at ValveKeyValue.Deserialization.KV1TextReader.ReadObject()
   at ValveKeyValue.KVSerializer.Deserialize(Stream stream, KVSerializerOptions options)
   at CKAN.SteamLibrary.<>c__DisplayClass3_0.<LibraryPathGames>b__0(String acfFile)
   at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext()
   at System.Linq.Enumerable.<SelectManyIterator>d__17`2.MoveNext()
   at System.Linq.Enumerable.<ConcatIterator>d__59`1.MoveNext()
   at System.Linq.Buffer`1..ctor(IEnumerable`1 source)
   at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)
   at CKAN.SteamLibrary..ctor()
   at CKAN.GameInstanceManager..ctor(IUser user, IConfiguration configuration)
   at CKAN.CmdLine.MainClass.Execute(GameInstanceManager manager, CommonOptions opts, String[] args)
   at CKAN.CmdLine.MainClass.Main(String[] args)

CKAN/Core/SteamLibrary.cs

Line 60 in 7568b2e

.Select(acfFile => acfParser.Deserialize<SteamGame>(File.OpenRead(acfFile))

[ZolderonGitHub]

Same problem here, is there any fix possible while the bug gets corrected?

[Halbann]

Also having this exception. My newly downloaded CKAN is at G:\Games\CKAN_2\ckan.exe and the path of my Steam install of KSP is G:\Games\Steam Library\steamapps\common\Kerbal Space Program, in case that's relevant. The path of my ACF file for KSP is G:\Games\Steam Library\steamapps\appmanifest_220200.acf. Could it be the space in the path?

[HebaruSan]

Hi @engiefox and @TheMainMan23 and @eecano and @kretze and @ZolderonGitHub and @Halbann, thanks for reporting this!

This error indicates a problem parsing one or more of the .acf files in your C:\Program Files (x86)\Steam\steamapps folder (or one of your other Steam library folders, if you have multiple) while CKAN is searching Steam for game instances. These files define the properties of your installed games, one per file, in Valve's proprietary KeyValue format (which looks oddly like KSP's .cfg format!), and typically they look like this:

Click to expand

We will probably have to simply ignore parsing errors in this step (presumably with some logging so it's clear which files won't parse), but it would be best to figure out what specifically is going wrong with those files. If you're able to help, please put your .acf files in a ZIP file and share it here so we can analyze them. (Do NOT ZIP the entire folder, since that will include all of your games, which in addition to being a copyright infringement to share, would also be extremely large! Just the .acf files, please.)
Or if you're comfortable browsing your .acf files in a text editor, feel free to do that instead or as well and let us know if you notice anything amiss.

Thanks!

[Halbann]

I stepped through the code and found it was just one acf file responsible that was just a few hundred null bytes with no text. I don't own the game it was for anymore. I deleted the file and CKAN worked fine after that.

Side note: the file was last modified in 2018 so it had obviously been there corrupted for some time without Steam cleaning it up.

[kretze]

I have several instances of ksp in my steam.
All additional instances are added as a non-steam game.

Original Kerbal Space Program

Back then I created KSP_x64_start.exe files using a BAT-to-EXE converter by setting the SteamAppID before KSP.exe
is started. So that the additional instances are registered as KSP in steam. I have no idea whether this still
has an impact on the data stored in Steam.

Batch to exe Converter -> KSP_x64_start.exe
@echo off
set SteamAppId=220200
KSP_x64.exe -single-instance

Manifest File
appmanifest_220200.acf.txt