[Bug]: Dark theme does not work

[infradmin4KSP]

Is there an existing issue for this?

• I have checked the existing issues for an existing issue. I even actually looked at the ones that are pinned to the top!

Operating System

Windows 10 22H2 build 19045.6456

CKAN Version

1.36.4.26132

Games

KSP 1

Game Version

1.12.5.3190

Did you make any manual changes to your game folder (i.e., not via CKAN)?

Yes and no, tried on different instances — does not matter.

Describe the bug

No dark theme when running ckan-windows.exe

Steps to reproduce

1. Run ckan-windows.exe;
2. Disappoint...

Relevant log output

No response

[infradmin4KSP]

CKAN window is in light theme though the dark one in the system.

[infradmin4KSP]

I think I know why. There is a mistype in the pull request #4594. It states:

When the net10.0-windows ckan-windows.exe build launches the GUI, if the registry key
HKEY_CURRENT_USER\SOFTWARE\Microsoft\CurrentVersion\Themes\Personalize\AppsUseLightTheme
is set to a value other than 1 (which is controlled by the display settings dark mode option), then GUI will start in dark mode

And CKAN really searches for this path:

But the proper path is
HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\CurrentVersion\Themes\Personalize
(you lost "Windows")

[infradmin4KSP]

May be there is something else. I tried to manually create the wrong key and... nothing changed:

[infradmin4KSP]

Works just fine on Windows 11. Is Win10 compatible?

[HebaruSan]

That may indeed be the case:

https://learn.microsoft.com/en-us/dotnet/api/system.windows.forms.application.setcolormode?view=windowsdesktop-10.0#remarks

Regarding the registry key, it does look like it is supposed to have "Windows" in it, but this also seems to be compensated for by the OS, in my testing. I toggled the setting, and CKAN changed its appearance on the next launch using the current key without "Windows".

[infradmin4KSP]

That's a pity...
So, thank you and please excuse me for disturbing you. Please close this issue.

[HebaruSan]

We might as well leave this open till we add "Windows" to the registry key. Thanks for raising this.

[infradmin4KSP]

seems to be compensated

Yes, on Win11 works without any "fixes" from my side.

[HebaruSan]

The registry key was fixed in #4628.