Adding Simplified Chinese Localization

[050644zf]

No description provided.

[HebaruSan]

Pasting from Discord:

[HebaruSan]

Mine looks the same except the "X files" string is translated, I think thanks to the addition of Main.zh-CN.resx:

[HebaruSan]

Test build for volunteer proofreaders

• ckan.zip

Switching to Chinese

1. Launch CKAN
2. Settings → CKAN settings
3. Under "More Settings", change the Language field to zh-CN
4. Close CKAN
5. Launch again; you should now see Chinese characters

Testing

Try to view every screen and read every piece of text. For example, a non-exhaustive list:

• Read all the menus
• Inspect the mod info pane on the right side
• Install a mod
  • With recommendations
  • With dependencies provided by multiple modules (e.g. Scatterer)
• Edit the settings
• Select / add / remove game instances
• Set the compatible KSP versions
• Export a modpack
• Import a modpack
• Anything else you can think of

Feedback

Please post a reply here with anything that doesn't look right or could be improved. Or even if you have questions or want to discuss.

Many strings will still be in English! In most cases this is because CKAN is divided into "Core" and "GUI" parts, and only the GUI is translated, while Core is English-only. In a few cases it might be because a GUI string was missed. Unfortunately there's no easy way to tell which is which, but if you ask, we can figure it out.

Remember that not everyone here can read Chinese (e.g., I can't), so comments about recommended changes should be specific enough that we can figure out what you're talking about. For example, a screenshot will be most useful if you draw a red circle around a problem.

[HebaruSan]

Mine looks the same

Hmm, not quite:

I wonder if those are caused by missing glyphs, bad wrapping, something else?

[050644zf]

And as for Chinese forum, yes we have some forum like tieba, bilibili, etc. I would like to post the test in our discord-like group first.

[050644zf]

Alright, I've posted Localization test in our group.

[tinygrox]

Too ugly.
Recommended change to "自动安装"
😃

[HebaruSan]

Pasting discussion from Discord for convenience:

As noted, the characters do not all fit into their allotted space, which we'll need to fix before merging. I can't tell the difference without a reference because I am not familiar with the characters, but it is easy enough to adjust the sizes as needed.

[HebaruSan]

Checklist while comparing the app to the resx files...

• File menu looks fine; skipping other menus and dropdowns since I think their size is auto-managed by Windows
• About window looks fine
• Toolbars look fine
• Tabstrip looks good
• Changeset tab page looks fine
• Mod info looks good
• Choose provided mods tab page looks fine
• Progress tab page looks OK
• Choose recommended mods tab page is good
• Delete directories tab page is OK
• Plugins dialog looks good
• Manage instances dialog is fine
  • Clone/fake instance dialog is fine
• Compatible versions dialog is good
• Settings looks fine, somehow (!)
  
• New repo dialog looks fine

Found a few untranslated strings:

Label on the Edit Labels window overlaps the dropdown:

And a few dialogs with bad sizes (pre-existing issue):

[HebaruSan]

The untranslated strings do have translations in the .zh-CN.resx files. I think "No available updates" is a case of trying to update a GUI property from a background thread, easily fixed. The progress tab page titles are a mystery, though. System.Console.WriteLine reports that we are passing English language strings to tabController.RenameTab. Figure that one out...

... maybe ResourceManager.GetObject also doesn't work on a background thread??
... confirmed. If I put the RenameTab calls inside Util.Invoke, then the translated string appears.

[HebaruSan]

Pushed a commit with fixes for the problems in my previous comments.

Since I'm not able to reproduce the issue with 1-2 pixels missing on some characters, I won't be able to work on addressing that. @050644zf, can you try editing the sizes yourself? They should all be in the .Designer.cs files, like this:

CKAN/GUI/Dialogs/SettingsDialog.Designer.cs

Line 397 in d0b3f83

this.CheckForUpdatesButton.Size = new System.Drawing.Size(112, 23);

It should be fine to make them slightly larger for all languages.

[050644zf]

@HebaruSan Now I edited the size to (112,25), comparing to the unmodified button, it does show the hidden pixel.

[HebaruSan]

Cool, if that size works then we can make all the buttons that big. Are there still any problems with the Settings dialog that you can see?

[050644zf]

Cool, if that size works then we can make all the buttons that big. Are there still any problems with the Settings dialog that you can see?

I think there is no problem now.

[HebaruSan]

Excellent! I think this looks great now, will merge shortly...
Thanks so much!