Set window title during startup#3841
Merged
Merged
Conversation
HebaruSan
added
Bug
techman83
approved these changes
May 19, 2023
Member
techman83
left a comment
techman83
left a comment
There was a problem hiding this comment.
Nice, a good and simple piece of polish. I like it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After #3829, the GUI window title is blank at startup:
It's set later, once the instance is loaded.
Cause
The window title depends on the name, version, and path of the game instance, so it's currently not set while the instance is loading.
Changes
Now we set an initial window title in
GUI.Main.OnLoadcontaining the pieces that are not dependent on having the instance loaded:The full title is still set later when the instance is loaded.