Caching and changeset fixes#3881
Merged
HebaruSan merged 1 commit intoAug 16, 2023
Merged
Conversation
techman83
approved these changes
Aug 16, 2023
Member
techman83
left a comment
There was a problem hiding this comment.
That's a great QoL improvement, thanks @HebaruSan !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
is:cachedandnot:cachedfilters updatedis:cachedandnot:cachedfilters are not updatedProblems
Causes
Changes
Core:
GroupByDownloadsfrom Support multiple download URLs per module #3877 is moved fromNetAsyncModulesDownloadertoCkanModulebecause it can have uses outside of downloadingOneDownloadGroupingPass, which is used to implement a new instance methodGetDownloadsGroupthat returns all mods in the given sequence that share a download ZIP with the current mod, without generating the other groupsGUI:
CkanModule.GetDownloadsGroupto update the cached status of all the mods that share a download ZIP with the selected modis:cachedis activeGUI.ModList's constructor no longer accepts a handler for itsModFiltersUpdatedevent; it's now a normal event, so calling code is updated to add handlers as needed, which will mean less jumping around the code to understand this aspect during maintenance.ModListobject as a parameter because calling code would already have access to it by virtue of subscribing to the event in the first place