Alternate game command lines and Steam refactor#4010
Merged
HebaruSan merged 1 commit intoFeb 1, 2024
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
d945cd2 to
f8d614c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
f8d614c to
2f001f9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
f665200 to
3a21749
Compare
|
Super cool. Thank you for doing this! |
3a21749 to
6c28153
Compare
This comment was marked as resolved.
This comment was marked as resolved.
088b838 to
29088c0
Compare
29088c0 to
95f8e1c
Compare
This was referenced Feb 2, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
If you're a Steam user, you can add extra game instances to Steam using this menu item:
Motivations
KSP_x64.exeorKSP2_x64.exedoesn't launch it through Steam. To count play time in Steam, you have to launch the game with Steam, which can be done either by clicking in Steam or with asteam://rungameid/URL.Changes
SteamLibraryclass that uses the newly referencedValveKeyValueMIT-licensed library to retrieve Steam's full list of games from its data filesconfig/libraryfolders.vdfinstead ofconfig/config.vdfbecause @Olympic1's additional folder was listed in the former but not the latterSteamApps/common/Kerbal Space Programexisting but being empty, which would have caused problems under the old logic but would correctly be ignored nowIGame.DefaultCommandLineis replaced byIGame.DefaultCommandLines, which uses theSteamLibraryclass to find the URL for each game when available in addition to the direct EXE file optionSide fixes:
ckan updatewon't spam "Loading modules from downloaded default repository..." anymoreFixes #2706.
Fixes #4003 (in that it explicitly tells the user whether Steam will count play time and makes the
steam://URL option discoverable).