Recommendations usability improvements#4025
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
OuterPlanetsModandUnKerballedStart, two of the latter's recommendations conflict with the former, so you have to uncheck them to continue:Changes
(In the below screenshot, Bureaucracy is in the Held label)
The dropdown button next to Uncheck All shows a menu with an Always uncheck all checkbox:
If you check this, then
GUIConfiguration.SuppressRecommendationsis set totrue, and the next time you come to the recommendations screen, nothing will be checked by default. You can uncheck the box to go back the normal defaulting behavior.The "Check" toolbar buttons become enabled and disabled based on whether any of their affected mods are unchecked, but the "Uncheck" button is always enabled because if we disable it we lose access to its dropdown menu.
Fixes #4011.
Fixes #4015.
Fixes #4016.