Update Artifact Signing#4117
Merged
Merged
Conversation
There has been a bump in the sign release action version, with a breaking change. This passes through the artifact id, which is now a requirement. #1354
Member
|
How do we attach the signed artifact to the release? |
HebaruSan
approved these changes
Jul 5, 2024
Member
HebaruSan
left a comment
There was a problem hiding this comment.
I guess this is just an API-compatibility update with no new or changed functionality.
Looks fine so far. 👍
Member
Author
|
There is either an url we can call, but we'd just set an output path output-artifact-directory: './_build-signed'Then attach it to the release run: gh release upload ${{ github.event.release.tag_name }} _build-signed/Release/ckan.exe
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}We'd probably also upload it as an artifact we can use for the rest of release artifacts to consume, and just switch everything out. It's the same directory structure as the repack-unsigned, so in theory if we upload it as 'repack-signed', we can just change everything from '-unsigned' to '-signed' with no other changes. For the nuget package, we'll have to sign that separately, but I think that's reasonable in the scheme of things. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 4 of SignPath/github-action-submit-signing-request required the following to be addressed:
We now have outputs to be able to pass that artifact id through the workflows to the signing action. Results of this working can be seen here -> https://github.com/KSP-CKAN/CKAN/actions/runs/9804590624
Extra
actions/cacheto v4