Recommendation suppression for modpacks#4147
Merged
Merged
Conversation
e9990a5 to
11ef1dc
Compare
11ef1dc to
f8785f9
Compare
Contributor
|
Seems to work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, in order to install the exact list of mods in a modpack, the user has to deselect the recommendations of all the mods. It would be nice to be able to skip this step.
It looks like setting
suppress_recommendationsfor each item in thedependslist should work, but it doesn't because those items get added as first class members of the changeset, which causes that property to be ignored in the modpack.A similar thing can happen in a normal changeset; if A and B are in the changeset, and both depend on C but only A has
suppress_recommendationsset, B's lack of the property will mean that C's recommendations are still shown. That probably frustrates the author of A, especially if they're from KSP-RO.Changes
suppress_recommendationsis obeyed if it is set for anydependsrelationship in the changeset, even if other mods have the same dependency without that property or if the dependency is in the changeset itself.depends[].suppress_recommendationsin a modpack will now work.suppress_recommendationsfor every relationship independsif unchecked, to make it easy to generate such metadata.Fixes #4145.