Ability to update repos without a game instance#4161
Merged
Conversation
HebaruSan
added
Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The
ckan updatecommand retrieves fresh metadata from repositories, but currently it requires a game instance to work. Since #3904, repositories and game instances have been decoupled somewhat, so this should not be strictly necessary anymore.Motivation
For https://github.com/KSP-CKAN/CKAN-ModInstaller, it would be nice to be able to pre-load the Docker image with metadata so a mod's build wouldn't have to wait for a
ckan updatecommand to run. Ideally we could do this without creating a temporary game instance during the docker build.Changes
Now the
ckan updatecommand has several new flags:-g KSP -u URL [URL2 ...]will update the repos with the given URLs, using the-gparameter to determine the game to use-g KSP/-g KSP2without-uwill update the default repo for the given game (limit one per command)-fwill force an update to be performed even if the repo's ETags haven't changed-lis now an alias for--list-changesThis will allow us to add these commands to the ModInstaller's Dockerfile to pre-load it with metadata: