Label search fixes#4187
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
-prefix like all other searchesIt has worked this way since #3323 (and #3460 even partially explained why), but no one seemed to care.
Recently we finally got a report from Discord user Epsilon:
Cause
ModSearchstoresstrings for tags butModuleLabels for labels. This was done because it's trivial to check whether a tag name matches a module by looking for it in theCkanModule.Tagsproperty, but the label object stores which mods it contains rather than the other way around. To check label membership, you need theModuleLabelobject, soModSearchstored them, which meant that when we translate it back into a search string, partially typed label searches could not be represented since there was no such label in the list of labels.Changes
ModSearch.Labelsis replaced with a string listModSearch.LabelNameswhich can contain partial names while the user is typingModSearch.MatchesLabelsis rewritten to handle looking up the labels fromModuleLabelList.ModuleLabelsand scan them for matching nameslabel:Favoritesmatches all mods in the Favories label if it exists.-label:Favoritesexcludes all mods in the Favories label if it exists.label:by itself matches all mods with no labels.-label:by itself excludes all mods with no labels.label:partialmatches nothing if there is no "partial" label.-label:partialmatches all mods if there is no "partial" label.