Sign releases, dev builds, and nuget package#4189
Merged
Merged
Conversation
HebaruSan
added
Build
HebaruSan
force-pushed
the
feature/signing
branch
from
1b4f61a to
a7a29f5
Compare
techman83
requested changes
Sep 22, 2024
Member
techman83
left a comment
techman83
left a comment
There was a problem hiding this comment.
Only change will be, can we update the Readme. Otherwise all looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
SignPath's action is ready, we have a certificate, and #4188 created a helper build target to collect assets for signing. The next step toward signing releases is updating our workflows.
Changes
build.ymluses the build target from Add Prepare-SignPath target to build script #4188 to upload an artifact containing the assets we need to sign for the Release configurationsign.ymlis created to retrieve that artifact, get it signed, and upload a newsignedartifact with the resultsrelease.ymlcallssign.ymlto generate signed assets for releasesdeploy.ymlcallssign.ymlto generate signed assets for uploading dev builds