Improvements for missing file checks#4213
Merged
Merged
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
As of #4067, manually deleting files installed by CKAN causes that mod to be shown as having an update that reinstalls the mod to restore the deleted files. This is to ensure that all CKAN-installed mods are installed correctly according to the instructions in their metadata.
Problems
FerramAerospaceResearchcontains a fileFARForceDataUpdate.cfgthat it deletes at run-time, which CKAN then detects as a missing file and prompts the user to re-install.Causes
Changes
Fixes [Bug]: Update all not checking the checkbox for mods with missing files #4207.
FARForceDataUpdate.cfgfile should be installed at least once (and presumably re-installed at each upgrade) to ensure the mod works as it's supposed to.Fixes [Feature] Ability to suppress missing file checks for files auto-deleted by mods #4204.