Generate and tidy up XML docs for Core#4351
Merged
Merged
Conversation
HebaruSan
added
Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Discord user Lewis has been coding against CKAN Core via the Nuget package. He has requested XML documentation be added to the package.
Changes
GenerateDocumentationFileis enabled forCKAN-core.csproj(the other projects aren't included in the .nupkg file)CS1591warning for missing documentation is turned off so we don't have 3000+ new warnings every time we compile.This way, the next release will have XML docs embedded in the .nupkg.