Skip to content

Show download errors popup for downloads from Contents tab#4366

Merged
HebaruSan merged 3 commits into
KSP-CKAN:masterfrom
HebaruSan:feature/failed-dl-popup-for-contents-tab
May 7, 2025
Merged

Show download errors popup for downloads from Contents tab#4366
HebaruSan merged 3 commits into
KSP-CKAN:masterfrom
HebaruSan:feature/failed-dl-popup-for-contents-tab

Conversation

@HebaruSan
Copy link
Copy Markdown
Member

Motivation

  • While investigating Inconsistency Kraken when installing OuterPlanets #930, I noticed that the validation error for KopernicusTech's old Dropbox link was being printed to the log instead of popping up the failed downloads popup. That turned out to be because I was downloading from the Contents tab, where it's not implemented.
  • Furthermore, that same error was showing the text for a DownloadErrorsKraken where it should have been getting to the point of the mismatched hash. Turns out that's because that's what the module downloader throws when Cache.Store throws InvalidModuleKraken.

Changes

  • Now if a download from the Contents tab fails, the failed downloads popup will appear.
  • Now we re-throw the same exception when Cache.Store fails, so the message will be normal.
    • In case there are any other instances of this left or added in the future, the downloader now detects when a download is directly associated with a DownloadErrorsKraken and extracts the original source exceptions when constructing the new DownloadErrorsKraken representing the whole group of downloads.

@HebaruSan HebaruSan added Bug Something is not working as intended Enhancement New features or functionality Easy This is easy to fix GUI Issues affecting the interactive GUI Core (ckan.dll) Issues affecting the core part of CKAN Network Issues affecting internet connections of CKAN labels May 7, 2025
@HebaruSan HebaruSan merged commit eccdb81 into KSP-CKAN:master May 7, 2025
2 checks passed
@HebaruSan HebaruSan deleted the feature/failed-dl-popup-for-contents-tab branch May 7, 2025 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something is not working as intended Core (ckan.dll) Issues affecting the core part of CKAN Easy This is easy to fix Enhancement New features or functionality GUI Issues affecting the interactive GUI Network Issues affecting internet connections of CKAN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant