Switch Inflator from Mono to dotnet#4387
Merged
Merged
Conversation
306c078 to
26640c7
Compare
Pull Request Test Coverage Report for Build 15503475519Details
💛 - Coveralls |
ed1eeaf to
7d6ca5d
Compare
bbc7147 to
31f7824
Compare
31f7824 to
3ca2b7a
Compare
Member
Author
Member
Author
|
... and this is why. https://github.com/actions/upload-artifact/blob/v4/docs/MIGRATION.md#hidden-files (In Unix, files that begin with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
While auditing Netkan code to try to make progress on the array bounds errors that occasionally show up in the status page, I noticed that:
netkan.exe --releases allwouldn't work becauseallwas translated intonullwhich later was defaulted to1in the chain of processing of that option.netkan.exe.Problem
See KSP-CKAN/NetKAN#10588, the progress bar for removing HideEmptyTechNodes looks weird, showing negative bytes remaining and greater than 100% completion:
Reported by Discord user Shadlock.
Cause
If a module's
install_sizedoesn't match up with what's on disk, then we end up removing a different number of bytes than expected. Bytes remaining is calculated naïvely by subtracting bytes completed frominstall_size, which can be negative if there are too many bytes. The percent completed works similarly.Changes
dotnet publishfor Netkan to generate a self-contained app for net8.0 and linux-x64Dockerfile.netkannow usesubuntu:latestagain because it no longer installs Mono, it installs the entire net8.0publishfolder for Netkan into/home/netkan, and itsENTRYPOINTnow runs the dotnet build ofCKAN-NetKAN_build/outinstead of_build/repack, and runs the Docker build in_build/out/CKAN-NetKAN/Release/bin/net8.0/linux-x64/publishinstead of_build/repack/Release.dockerignorefile contains all the DLLs that I was able to confirm are not needed, as a halfway measure until we are able to get real trimming to work./usr/local/etc/metadata.inias specified in Get netkan and ckan commands from config file xKAN-meta_testing#101, which we can use later to make it use dotnet instead of Mono (which is not attempted here).--releases alloption will properly inflate all releases.netkan.exe, and all will be inflated.ModuleInstallersanity checks the numbers that it sends out for status updates, so negative bytes remaining will no longer be seen for mods with bigger than expected files.Note that we may not get a new dev build after merging this, depending on whether the SignPath action continues to error out as in SignPath/github-action-submit-signing-request#9.