A few more tests#4426
Merged
Merged
Conversation
HebaruSan
added
GUI
Pull Request Test Coverage Report for Build 17385609546Details
💛 - Coveralls |
Member
Author
|
Nice! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Coveralls says we're up to 67%, which is an improvement, but not comfortable enough to be an end state.
Changes
New tests are added for:
ckan importNameComparer(used only for printing mods after
repo update, and required sorting them alphanumerically)GUI.EmbeddedImagesGUI.ReleaseStatusItemNetKAN.CmdLineOptionsNetKAN.ModuleService.GetSpaceWarpInfo(FYI to @JohnsterSpaceProgramOfficial, we're borrowing your
BurnController-0.8.1.zipfor testing, since it is MIT-licensed. We'll just be using it to confirm that we can extract and parse theswinfo.jsoncorrectly.)More untestable code is excluded from coverage:
GUI.ControlFactoryGUI.FormCompatibilityGUI.WinFormsExtensionsGUI.GUIGUI.X11Unused code is deleted:
InconsistentKrakenhandler inCmdLine.MainServiceLocator.Container's setterGUI/Properties/Settings.*