Skip to content

Report number of filtered files in install#4443

Merged
HebaruSan merged 23 commits into
KSP-CKAN:masterfrom
HebaruSan:add/small-tests
Sep 22, 2025
Merged

Report number of filtered files in install#4443
HebaruSan merged 23 commits into
KSP-CKAN:masterfrom
HebaruSan:add/small-tests

Conversation

@HebaruSan
Copy link
Copy Markdown
Member

@HebaruSan HebaruSan commented Sep 22, 2025

Motivation

  • In Mods installation problem (windows) #4436, a user accidentally created a global installation filter of i, so all files containing i anywhere in their path were blocked from installing. It would be nice if this was easier to catch.
  • We're still at a red status on Coveralls.
  • I noted that several translated strings were contributed on Crowdin since the last import of translations, so I tried to download them. To my surprise, those strings were missing from the downloaded source archive.
    Some investigation led me to this checkbox:
    image
    This setting was checked, and it was excluding many translated strings from the download because other unrelated strings weren't translated yet, which makes no sense for our usage.

Changes

  • Now when we report successful installation, if any files were filtered out by install filters, the message says how many. This way a user with an errant install filter would see things like "(69 files filtered out)", hopefully giving a clue of what is happening.
  • A whole bunch of missing already translated strings are now translated. My apologies to their contributors for not attributing them, but there are a lot of strings and digging up when they were added and by whom would be very onerous given how all of this works. Thank you so much regardless!
  • Tests are added for:
    • any_of relationships
    • Module labels
    • DictionaryEquals
    • ckan available without details
    • Compatibility warning identifiers loading
    • ModuleVersion.StripEpoch and StripV
    • buildID.txt creation for fake instances
    • DirectoryLink
    • More of GithubTransformer and GithubApi
    • More of GameInstance
    • Invalid x_netkan_version_edit input
    • More of NetKAN.Model.Metadata

@HebaruSan HebaruSan added Enhancement New features or functionality GUI Issues affecting the interactive GUI Cmdline Issues affecting the command line Core (ckan.dll) Issues affecting the core part of CKAN Tests Issues affecting the internal tests Registry Issues affecting the registry i18n Issues regarding the internationalization of CKAN and PRs that need translating labels Sep 22, 2025
@HebaruSan HebaruSan merged commit 01ce542 into KSP-CKAN:master Sep 22, 2025
4 checks passed
@HebaruSan HebaruSan deleted the add/small-tests branch September 22, 2025 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cmdline Issues affecting the command line Core (ckan.dll) Issues affecting the core part of CKAN Enhancement New features or functionality GUI Issues affecting the interactive GUI i18n Issues regarding the internationalization of CKAN and PRs that need translating Registry Issues affecting the registry Tests Issues affecting the internal tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant