Report number of filtered files in install#4443
Merged
Merged
Conversation
game => Game GameDir() => GameDir CkanDir() => CkanDir DownloadCacheDir() => DownloadCacheDir InstallHistoryDir() => InstallHistoryDir GetCompatibleVersions() => CompatibleVersions string => GameVersion
3c2b66d to
be9b921
Compare
be9b921 to
7bbd4e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
i, so all files containingianywhere in their path were blocked from installing. It would be nice if this was easier to catch.Some investigation led me to this checkbox:
This setting was checked, and it was excluding many translated strings from the download because other unrelated strings weren't translated yet, which makes no sense for our usage.
Changes
any_ofrelationshipsDictionaryEqualsckan availablewithout detailsModuleVersion.StripEpochandStripVbuildID.txtcreation for fake instancesDirectoryLinkGithubTransformerandGithubApiGameInstancex_netkan_version_editinputNetKAN.Model.Metadata