Fix symlinks being generated on Linux#4519
Merged
Merged
Conversation
Pull Request Test Coverage Report for Build 22550387682Details
💛 - Coveralls |
|
I recently ran into this issue and looked at it in some detail. If it is desirable to create symlinks for the purpose of saving storage, it does work correctly if the symlink tree is created one level further down, i.e. instead of linking KSP_Data linking the contents of KSP_Data. I "repaired" the instances on my system by using the attached shell script which did exactly this. That being said, this is not an issue if the data is on the same file system and hard links are used instead. (I did not mess with KSPLauncher_Data since it didn't seem to have the same problem as KSP_Data.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#4441 intended to suppress symlinks when cloning instances on Linux, but it didn't work; symlinks are still being generated.
Reported by @PewPewCricket on Discord and #4441 (comment).
Cause
I updated the default for the
Checkedproperty, butCheckedStateis set to the opposite value on the next line, so the hidden checkbox was still always checked. 🤦Changes
CheckedStatedefaults toUnchecked, so there will actually not be symlinks on Linux.ini-parser's actual latest version is 2.5.2; 3.4.0 was a typo'd duplicate of 2.4.0 that was de-listed from Nuget. However, Nuget does not allow fully deleting releases, because it would break builds.Our reference is now updated from 3.4.0 to 2.5.2.