Try to stop users from cloning instances into themselves#4556
Merged
HebaruSan merged 1 commit intoApr 12, 2026
Conversation
Coverage Report for CI Build 24295459733Coverage increased (+0.04%) to 85.543%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
If a user clones a game instance into a subfolder of itself, the copy goes on forever and eventually fills the disk if not stopped.
Changes
Now when you clone an instance, we check whether any of the parent folders of the destination are the same as the source, and if so we emit an error and abort the clone.
A test is included to exercise this.
Fixes #4520.
Known limitations
Note that catching all ways to try to copy a directory into itself is a well-known impossible task, because different paths can point to the same location in obfuscated ways:
While we can't detect everything, catching the very simplest case where everything is a normal directory is still easy enough to be worth it.