Remove symlink-based DLL deduplication from MacOS build#4557
Merged
HebaruSan merged 1 commit intoApr 21, 2026
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
Author
|
Test build expired with no response from user. |
|
I'm sorry I was away for a while so I'm only just seeing this. I'm aware this issue has been closed and I was unable to try the test build, however I didn't come across the issue again thereafter. Thank you so much either way I didn't expect such a helpful and speedy response. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A Mac user reported this error on launch:
Cause
This is still being investigated, but my current best guess is that System.Runtime.dll isn't loading because it's a symlink to the identical copy of that file in
../x86_64/. I thought we had tested this already in #4410 and #4418, but maybe those tests were flawed somehow.Changes
Now we just build the big bloated version of the CKAN.app with two copies of many files, one per architecture, instead of replacing duplicates with symlinks. This will allow us to test whether this solves the problem.
Fixes #4542 (maybe, needs confirmation from @robism05).
Looks like the file size difference is about 14 MB:
Before:

After: