DPI-based font scaling for Mono#4566
Merged
Merged
Conversation
Coverage Report for CI Build 24449855110Coverage decreased (-0.1%) to 85.427%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions18 previously-covered lines in 2 files lost coverage.
Coverage Stats💛 - Coveralls |
53d4245 to
15c1ceb
Compare
|
OMG LET'S GOOOOO. Waited for this for sooo long)) |
|
Would it be possible to make a special release for this one ? It seems that it is a long awaited feature ? Thanks ! |
Member
Author
|
@hivert, there are already dev builds available that include all recent changes:
... and there will be a regular release of this soon enough. |
Merged
|
Hey, glad that you picked up the torch and was able to complete the task. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Pixels are smaller than they used to be. 96 DPI was traditional, but 120 and 144 DPI are now common. I recently upgraded to a 144 DPI setup, and the CKAN GUI looks quite tiny and hard to read in Linux.
#4543 addressed this for Windows by switching to DPI-based auto-scaling and point-based font sizes. Mono's WinForms implementation seems to auto scale the sizes of controls based on those things, but not the fonts.
#4465 did some work for configurable font scaling, but it needed some new tests to avoid decreasing the coverage percentage and wasn't finished.
Changes
WebClient.Encodingto UTF-8, which is a superior solution to [Bug]: Abstracts from GitHub API replace non-ASCII characters with question marks #4288 than Set unicode-aware locale in containers #4289 because it will work regardless of how the surrounding environment is set up.Fixes #878.