-
Notifications
You must be signed in to change notification settings - Fork 365
[Experiment] AbsoluteValue with Claude implementation #3304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3cc460d
[LEMS-3936/absolute-ai] test Claude on ticket
handeyeco daa098f
[LEMS-3936/absolute-ai] fix Knip issues
handeyeco 84a3710
[LEMS-3936/absolute-ai] Merge branch 'main' into LEMS-3936/absolute-ai
handeyeco bf97eac
[LEMS-3936/absolute-ai] add document note thing
handeyeco 8b079d4
[LEMS-3936/absolute-ai] add checklist
handeyeco 4809cd5
[LEMS-3936/absolute-ai] finish implementation
handeyeco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,6 +10,7 @@ import type { | |
| LockedPointType, | ||
| LockedPolygonType, | ||
| LockedVectorType, | ||
| PerseusGraphTypeAbsoluteValue, | ||
| PerseusGraphTypeAngle, | ||
| PerseusGraphTypeCircle, | ||
| PerseusGraphTypeLinear, | ||
|
|
@@ -145,6 +146,19 @@ export function generateIGSinusoidGraph( | |
| }; | ||
| } | ||
|
|
||
| export function generateIGAbsoluteValueGraph( | ||
| options?: Partial<Omit<PerseusGraphTypeAbsoluteValue, "type">>, | ||
| ): PerseusGraphTypeAbsoluteValue { | ||
| return { | ||
| type: "absolute_value", | ||
| coords: [ | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TODO: double check this, it doesn't seem to match the others. |
||
| [0, 2], | ||
| [2, 0], | ||
| ], | ||
| ...options, | ||
| }; | ||
| } | ||
|
|
||
| export function generateIGLockedPoint( | ||
| options?: Partial<Omit<LockedPointType, "type">>, | ||
| ): LockedPointType { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83 changes: 83 additions & 0 deletions
83
...-editor/src/widgets/interactive-graph-editor/start-coords/start-coords-absolute-value.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| import {View} from "@khanacademy/wonder-blocks-core"; | ||
| import {Strut} from "@khanacademy/wonder-blocks-layout"; | ||
| import {semanticColor, font, spacing} from "@khanacademy/wonder-blocks-tokens"; | ||
| import { | ||
| BodyMonospace, | ||
| LabelLarge, | ||
| LabelMedium, | ||
| } from "@khanacademy/wonder-blocks-typography"; | ||
| import {StyleSheet} from "aphrodite"; | ||
| import * as React from "react"; | ||
|
|
||
| import CoordinatePairInput from "../../../components/coordinate-pair-input"; | ||
|
|
||
| import {getAbsoluteValueEquation} from "./util"; | ||
|
|
||
| import type {Coord} from "@khanacademy/perseus"; | ||
|
|
||
| type AbsoluteValueCoords = [Coord, Coord]; | ||
|
|
||
| type Props = { | ||
| startCoords: AbsoluteValueCoords; | ||
| onChange: (startCoords: AbsoluteValueCoords) => void; | ||
| }; | ||
|
|
||
| const StartCoordsAbsoluteValue = (props: Props) => { | ||
| const {startCoords, onChange} = props; | ||
|
|
||
| return ( | ||
| <> | ||
| {/* Current equation */} | ||
| <View style={styles.equationSection}> | ||
| <LabelMedium>Starting equation:</LabelMedium> | ||
| <BodyMonospace style={styles.equationBody}> | ||
| {getAbsoluteValueEquation(startCoords)} | ||
| </BodyMonospace> | ||
| </View> | ||
|
|
||
| {/* Points UI */} | ||
| <View style={styles.tile}> | ||
| <LabelLarge>Vertex:</LabelLarge> | ||
| <Strut size={spacing.small_12} /> | ||
| <CoordinatePairInput | ||
| coord={startCoords[0]} | ||
| labels={["x", "y"]} | ||
| onChange={(value) => onChange([value, startCoords[1]])} | ||
| /> | ||
| </View> | ||
| <View style={styles.tile}> | ||
| <LabelLarge>Point 2:</LabelLarge> | ||
| <Strut size={spacing.small_12} /> | ||
| <CoordinatePairInput | ||
| coord={startCoords[1]} | ||
| labels={["x", "y"]} | ||
| onChange={(value) => onChange([startCoords[0], value])} | ||
| /> | ||
| </View> | ||
| </> | ||
| ); | ||
| }; | ||
|
|
||
| const styles = StyleSheet.create({ | ||
| tile: { | ||
| backgroundColor: semanticColor.core.background.instructive.subtle, | ||
| marginTop: spacing.xSmall_8, | ||
| padding: spacing.small_12, | ||
| borderRadius: spacing.xSmall_8, | ||
| flexDirection: "row", | ||
| alignItems: "center", | ||
| }, | ||
| equationSection: { | ||
| marginTop: spacing.small_12, | ||
| }, | ||
| equationBody: { | ||
| backgroundColor: semanticColor.core.background.neutral.subtle, | ||
| border: `1px solid ${semanticColor.core.border.neutral.subtle}`, | ||
| marginTop: spacing.xSmall_8, | ||
| paddingLeft: spacing.xSmall_8, | ||
| paddingRight: spacing.xSmall_8, | ||
| fontSize: font.size.xSmall, | ||
| }, | ||
| }); | ||
|
|
||
| export default StartCoordsAbsoluteValue; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: the other types use
CollinearTuple.