Improve schema and user input type documentation#3357
Draft
jeremywiebe wants to merge 3 commits intomainfrom
Draft
Improve schema and user input type documentation#3357jeremywiebe wants to merge 3 commits intomainfrom
jeremywiebe wants to merge 3 commits intomainfrom
Conversation
Contributor
🗄️ Schema Change: Changes Detected
|
Contributor
|
Size Change: 0 B Total Size: 486 kB ℹ️ View Unchanged
|
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (13686c8) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3357If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3357If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3357 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR is strictly comment changes.
We have decent coverage of comments in
data-schema.ts, but they are not JSDoc comments, and so many tools don't display these comments with the type where it's used. This PR converts all relevant// ...comments to true JSDoc comments/** ... */.We also add/enhance JSDoc comments for all user input, validation, and rubric types in
validation.types.ts.This should help human authors as they work with these types, but we anticipate it also helping AI agents to understand the types much better.
NOTE: The Schema Change check triggered but as you can see in the diff, it's only comment changes so it's a false report. Eventually we should probably filter comments out from that diff.
Issue: LEMS-3949
Test plan:
This is strictly documentation, so reading new comments would be helpful.