You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@MarkCallow, we did not implement scaling, so I have no idea whether this is the right order of operations, therefore I'm not sure I can provide an informed review of this without understanding the details how scaling was added.
@MarkCallow, we did not implement scaling, so I have no idea whether this is the right order of operations, therefore I'm not sure I can provide an informed review of this without understanding the details how scaling was added.
Thanks for looking. --generate-mipmap is also affected by this bug as both it and --scale use the resample method to resize images. Not having the color space set before scaleImage and generateMipLevels are called results in Image::resample always seeing _UNSPECIFIED and so never decoding sRGB images. The color space must be set before these functions are called. I am confident this is the correct order so I am going to merge this.
I am not too surprised the issue was missed when the --generate-mipmap tests were added as the differences between correct and incorrect images are very subtle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1050.