[CMake] Make LLVMSPIRVLib include directories PUBLIC for in-tree builds#3590
Open
wenju-he wants to merge 1 commit intoKhronosGroup:mainfrom
Open
[CMake] Make LLVMSPIRVLib include directories PUBLIC for in-tree builds#3590wenju-he wants to merge 1 commit intoKhronosGroup:mainfrom
wenju-he wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
LLVMSPIRVLib provides a public API through headers like LLVMSPIRVLib.h,
LLVMSPIRVOpts.h, and LLVMSPIRVExtensions.inc. Any target that links to
LLVMSPIRVLib and calls its functions must include these headers.
Currently, the include directory is marked PRIVATE, which prevents CMake
from automatically propagating include paths to downstream targets. This
forces consumers to manually add the include directories.
This commit makes the include directory PUBLIC with BUILD_INTERFACE,
following standard CMake practice for libraries with public APIs. This
allows targets linking to LLVMSPIRVLib to automatically get the correct
include paths, which is necessary for in-tree consumers like opencl-clang.
Changes:
- lib/SPIRV/CMakeLists.txt: Move ${LLVM_SPIRV_INCLUDE_DIRS} from PRIVATE
to PUBLIC with $<BUILD_INTERFACE:...> generator expression
- tools/llvm-spirv/CMakeLists.txt: Remove redundant explicit include since
it's now automatically propagated via CMake target propagation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
svenvh
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLVMSPIRVLib provides a public API through headers like LLVMSPIRVLib.h, LLVMSPIRVOpts.h, and LLVMSPIRVExtensions.inc. Any target that links to LLVMSPIRVLib and calls its functions must include these headers.
Currently, the include directory is marked PRIVATE, which prevents CMake from automatically propagating include paths to downstream targets. This forces consumers to manually add the include directories.
This commit makes the include directory PUBLIC with BUILD_INTERFACE, following standard CMake practice for libraries with public APIs. This allows targets linking to LLVMSPIRVLib to automatically get the correct include paths, which is necessary for in-tree consumers like opencl-clang.
Changes: