Conversation
…ng sent back as assistant message content (#11270) Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com>
Co-authored-by: Github Action <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: aaroniker <[email protected]>
![kiloconnect[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| console.log(` Failed to fetch PR #${pr.number}, skipping`) | ||
| skipped.push({ number: pr.number, reason: "Failed to fetch" }) | ||
| console.log(" Fetching PR head...") | ||
| const fetch = await run(["git", "fetch", "origin", `pull/${pr.number}/head:pr/${pr.number}`]) |
There was a problem hiding this comment.
CRITICAL: git fetch ... pull/<n>/head:pr/<n> can fail when the branch name contains slashes
Git disallows some refname characters in local refs (notably : in refspecs is fine, but the destination ref pr/<n> is okay; the bigger issue is pull/<n>/head resolves fine, but local branch creation via refspec still risks conflicts if the ref already exists or is checked out). Consider using git fetch origin pull/${pr.number}/head without creating a local ref, or fetch into refs/remotes/pr/${pr.number} to avoid polluting local branches.
| const match = transform.match(/matrix(?:3d)?\(([^)]+)\)/) | ||
| if (!match) return 0 | ||
|
|
||
| const values = match[1].split(",").map((v) => parseFloat(v.trim())) |
There was a problem hiding this comment.
WARNING: parseFloat of the transform matrix can yield NaN, which then propagates into effectiveScrollPos and breaks fade calculation
If any matrix value is NaN, Math.max(scrollPos, transformPos) becomes NaN and the component will stop updating properly. Defensive filtering (e.g., defaulting NaN to 0) would avoid a hard-to-debug UI state.
| } | ||
|
|
||
| const render = (element: JSX.Element, id: string, owner: Owner) => { | ||
| setRenders((renders) => ({ ...renders, [id]: element })) |
There was a problem hiding this comment.
WARNING: setRenders((renders) => ({ ...renders, [id]: element })) can cause unbounded growth if render() is called repeatedly with new ids and dialogs never close
renders acts like a registry; if callers generate ids dynamically and never trigger the onClose cleanup, entries will accumulate. Consider documenting that id must be stable, or adding a guard/eviction strategy.
Code Review SummaryStatus: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
WARNING
Files Reviewed (8 files)
|
8 participants
https://github.com/anomalyco/opencode/releases/tag/v1.1.46
Core
Desktop
Thank you to 3 community contributors:
feat: Transitions, spacing, scroll fade, prompt area update (feat: Transitions, spacing, scroll fade, prompt area update anomalyco/opencode#11168)
test(app): change language test (test(app): change language test anomalyco/opencode#11295)
chore(tui): remove unused experimental keys (chore(tui): remove unused experimental keys anomalyco/opencode#11195)