Skip to content

Downgrade to history v4#2180

Merged
leplatrem merged 1 commit into
masterfrom
downgrade-history
Nov 16, 2021
Merged

Downgrade to history v4#2180
leplatrem merged 1 commit into
masterfrom
downgrade-history

Conversation

@leplatrem

Copy link
Copy Markdown
Contributor

@grahamalama grahamalama left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you think of a way we could write a test for this that fails with history@^5 but passes with history@^4 to prevent future regressions?

@leplatrem

Copy link
Copy Markdown
Contributor Author

Can you think of a way we could write a test for this that fails with history@^5 but passes with history@^4 to prevent future regressions?

Something around following links / navigation. I don't know yet whether this would require a full browser or not.

@grahamalama

Copy link
Copy Markdown
Contributor

Alternatively, maybe we can upgrade our build process to use npm v7 because of how peer dependencies are treated:

In previous versions of npm (4-6), peer dependencies conflicts presented a warning that versions were not compatible, but would still install dependencies without an error. npm 7 will block installations if an upstream dependency conflict is present that cannot be automatically resolved.

@leplatrem

Copy link
Copy Markdown
Contributor Author

Good catch! Yes! I was indeed wondering why peer deps were not blocking anything here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants