Remove sceneInfra and sceneEntitiesManager from buildSingletons return#10210
Draft
franknoirot wants to merge 4 commits intomainfrom
Draft
Remove sceneInfra and sceneEntitiesManager from buildSingletons return#10210franknoirot wants to merge 4 commits intomainfrom
sceneInfra and sceneEntitiesManager from buildSingletons return#10210franknoirot wants to merge 4 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separated out from #10119 because it's so dang noisy. Towards #9956, and evaporating
buildSingletons()into nothing. Simply accesses these systems throughkclManager, which was always close at hand wherever they were anyway.