feat: set up sandbox for script execution [INS-3378]#6991
Closed
feat: set up sandbox for script execution [INS-3378]#6991
Conversation
ihexxa
changed the title
Contributor
|
We should document the intended lifetime of the hidden browser window, eg. app start->app close or per function call, or whatever. |
Contributor
Author
|
@jackkav It sounds reasonable, I've updated its design and workflow in the doc, please have a look. |
Contributor
Author
|
Will create a naive version for this. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| hiddenBrowserWindow.loadURL(hiddenBrowserWindowUrl); | ||
|
|
||
| console.log( | ||
| `[main][init hidden win step 1/6]: starting hidden browser window(id=${hiddenBrowserWindow.id}): `, |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: javascript.lang.security.audit.unsafe-formatstring.unsafe-formatstring
…re are multiple windows now
chore: refactor table driven tests into the normal style
jackkav
force-pushed
the
feat-sandbox-mini
branch
from
1358986 to
2ad8d17
Compare
This was referenced Feb 5, 2024
Merged
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
This change basically sets up a sandbox which is an isolated environment for executing scripts, it contains following changes: