Skip to content

feat: append to timelines#7070

Merged
jackkav merged 7 commits intoKong:developfrom
jackkav:feat/support-appendable-timelines
Feb 7, 2024
Merged

feat: append to timelines#7070
jackkav merged 7 commits intoKong:developfrom
jackkav:feat/support-appendable-timelines

Conversation

@jackkav
Copy link
Contributor

@jackkav jackkav commented Feb 7, 2024

in order to support pre requests logging to timeline before request is made we need to make the file format open to be appended to.

also helps to align timeline read/write implementation with curl.ts and websocket.ts

todo:

  • fix unit tests
  • fix request hanging

maybe:

  • investigate making second filestream in main pointing at the same path

@jackkav jackkav requested a review from gatzjames February 7, 2024 13:06
@jackkav jackkav force-pushed the feat/support-appendable-timelines branch from 6c84cb9 to ab123cd Compare February 7, 2024 13:08
@jackkav jackkav force-pushed the feat/support-appendable-timelines branch from ab123cd to 337d95c Compare February 7, 2024 13:55
filfreire
filfreire previously approved these changes Feb 7, 2024
@jackkav jackkav merged commit 112a1c8 into Kong:develop Feb 7, 2024
@jackkav jackkav deleted the feat/support-appendable-timelines branch February 7, 2024 17:51
jackkav added a commit to jackkav/insomnia that referenced this pull request Mar 13, 2024
* working pass

* fix tests

* fix await issue with streams

* fix test

* fix mockbin test

* move to main

* inso cli test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants