fix: Export popup has small z-index [INS-3640]#7187
Conversation
115f58c to
15d9eb3
Compare
ihexxa
left a comment
There was a problem hiding this comment.
Thanks for the quick fix, good job👍.
There was a problem hiding this comment.
Rather than syncing the zlndex's with a hook we could try to remove the zindex settings? @gatzjames ?
gatzjames
left a comment
There was a problem hiding this comment.
We are moving away from the base/modal and using react-aria-components modals instead.
I'd suggest changing the settings-modal.tsx to have the same z-index as other modals instead.
In settings-modal.tsx line 44
<Modal className='!z-10' ref={modalRef} tall {...props}>
...
</Modal>That way the last modal to open will always be on top and there's no need to keep calculations in state.
This way works. And do we have other similar scenes that import the base/modal? I'm worried that if there are similar scenes that are not covered by the same z-index, there may be the same issue. @gatzjames |
15d9eb3 to
d14973d
Compare
There are definitely more modals that use the previous approach. |
Close #7176
Changes
How to test