Skip to content

feat: enable external modules in pre-request script - INS-3379#7257

Merged
jackkav merged 2 commits intodevelopfrom
pre-req-external-mods
Apr 15, 2024
Merged

feat: enable external modules in pre-request script - INS-3379#7257
jackkav merged 2 commits intodevelopfrom
pre-req-external-mods

Conversation

@ihexxa
Copy link
Copy Markdown
Contributor

@ihexxa ihexxa commented Apr 11, 2024

Background

This change does several things:

  • enable external modules for pre-request scripts
  • add tests

And this change also resolves several concerns:

  • these external dependencies can be accessed from main renderer but they are not used by it
  • these external dependencies increase main renderer bundle size
  • these external dependencies should be isolated with others, so that are able to manage those dependencies' version
  • no performance regression is detected

@ihexxa ihexxa marked this pull request as draft April 11, 2024 02:42
@ihexxa ihexxa self-assigned this Apr 11, 2024
@ihexxa ihexxa force-pushed the pre-req-workspace branch 2 times, most recently from 64c3deb to 5c4594c Compare April 12, 2024 13:03
Base automatically changed from pre-req-workspace to develop April 12, 2024 14:24
@ihexxa ihexxa force-pushed the pre-req-external-mods branch from 9e41107 to c8818d1 Compare April 15, 2024 02:52
@ihexxa ihexxa marked this pull request as ready for review April 15, 2024 03:14
@ihexxa ihexxa requested review from gatzjames and jackkav April 15, 2024 03:14
@jackkav jackkav merged commit 6c63b0d into develop Apr 15, 2024
@jackkav jackkav deleted the pre-req-external-mods branch April 15, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants