feat: add fallback for searching a proper client certificate for a host [INS-3680]#7259
Merged
CurryYangxx merged 4 commits intodevelopfrom Apr 15, 2024
Merged
feat: add fallback for searching a proper client certificate for a host [INS-3680]#7259CurryYangxx merged 4 commits intodevelopfrom
CurryYangxx merged 4 commits intodevelopfrom
Conversation
CurryYangxx
changed the title
notjaywu
reviewed
Apr 12, 2024
| expect(urlMatchesCertHost(certificateHost, requestUrl)).toBe(false); | ||
| }); | ||
|
|
||
| it('should return true if the request URL and certificate host have different ports and the needCheckPort parameter is false', () => { |
Contributor
There was a problem hiding this comment.
Does the case below return true?
const requestUrl = 'https://www.example.org:1234/some/resources?query=1';
const certificateHost = 'https://www.example.org';
Member
Author
There was a problem hiding this comment.
Yes, I added more test cases and the results are meet the requirements
CurryYangxx
force-pushed
the
feat/client-cert-fallback
branch
from
305fe7c to
898d82d
Compare
CurryYangxx
force-pushed
the
feat/client-cert-fallback
branch
from
898d82d to
4b2ae87
Compare
ihexxa
approved these changes
Apr 15, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes:
needCheckPortin urlMatchesCertHost